src/features/vim/hooks/use-vim-keyboard.ts (1)

480-556: Drop verbose console logging from applyMotion.

Lines 480-556: the console.log instrumentation fires on every visual motion and will spam the console in normal usage. Please remove it or wrap it behind an explicit debug flag so production builds stay clean.

-        console.log("=== applyMotion START ===");
-        console.log("Motion keys:", motionKeys);
-
-        const vimStoreBefore = useVimStore.getState();
-        console.log("Before motion - visualSelection:", vimStoreBefore.visualSelection);
-        console.log("Before motion - cursor:", useEditorStateStore.getState().cursorPosition);
-
         let success = false;
 
         if (isNewParserEnabled()) {
           const result = parseGrammar(motionKeys);
           if (result.status === "complete") {
             success = executeAST(result.command);
           }
         } else {
           success = executeVimCommand(motionKeys);
         }
 
         if (!success) {
           console.warn("Failed to execute visual motion:", motionKeys.join(""));
           return false;
         }
 
         const newPosition = useEditorStateStore.getState().cursorPosition;
         const lines = useEditorViewStore.getState().lines;
         const vimStore = useVimStore.getState();
-
-        console.log("After motion - cursor:", newPosition);
-
-
-        // Get fresh visual selection state
         const currentVisualSelection = vimStore.visualSelection;
         const currentVisualMode = vimStore.visualMode;
-
-        console.log("After motion - visualSelection from store:", currentVisualSelection);
 
         if (currentVisualSelection.start) {
           // Line mode: always select full lines
           if (currentVisualMode === "line") {
             const newStart = { line: currentVisualSelection.start.line, column: 0 };
             const newEnd = { line: newPosition.line, column: lines[newPosition.line].length };
-            console.log("Setting line visual selection:", newStart, "to", newEnd);
             vimStore.actions.setVisualSelection(newStart, newEnd);
           } else {
             // Char/block mode: select from start to cursor
             const newEnd = { line: newPosition.line, column: newPosition.column };
-            console.log(
-              "Setting char/block visual selection:",
-              currentVisualSelection.start,
-              "to",
-              newEnd,
-            );
             vimStore.actions.setVisualSelection(currentVisualSelection.start, newEnd);
           }
         }
 
         // Update textarea selection
         const textarea = document.querySelector(".editor-textarea") as HTMLTextAreaElement;
         if (textarea && currentVisualSelection.start) {
           const startOffset = calculateOffsetFromPosition(
             currentVisualSelection.start.line,
             currentVisualSelection.start.column,
             lines,
           );
           const endOffset = newPosition.offset;
-
-          console.log("Textarea offsets - start:", startOffset, "end:", endOffset);
-          console.log(
-            "Setting textarea selection:",
-            Math.min(startOffset, endOffset),
-            "to",
-            Math.max(startOffset, endOffset),
-          );
-
           textarea.selectionStart = Math.min(startOffset, endOffset);
           textarea.selectionEnd = Math.max(startOffset, endOffset);
 
           // Don't dispatch select event - it causes cursor position to be overridden
           // textarea.dispatchEvent(new Event("select"));
         }
-
-        console.log("=== applyMotion END ===\n");

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/features/vim/stores/vim-store.ts (2)

42-42: Consider stronger typing for the AST command.

The any type loses compile-time safety. If the grammar parser defines a Command or ASTNode type, use that instead to catch misuse at build time.

For example:

-  lastRepeatableCommand: any | null; // Store the last Command AST for repeat (.) functionality
+  lastRepeatableCommand: Command | null; // Store the last Command AST for repeat (.) functionality

---

283-283: Simplify the legacy register sync condition.

The !name check is unnecessary since name is typed as string (not nullable). Simplify to just name === '"'.

-            if (name === '"' || !name) {
+            if (name === '"') {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro